At least it works on r6976

Yes, we introduced this bug in beta5 and was fixed in beta6. Could you try trunk?

Hi Jesus,

I tried using r7801 of trunk just now and it's still there.

Hhhmmmghh, it seems there are two problems

1. NoesisGUI samples crashed on Win7 SP1

This is due to commit on r7369. NoesisGUI called an API of XInput_4.dll which only supported on Windows 8 or above. Thus failing in Win7 SP1. This is still happening even on trunk r7801.

2. Our app crashed on Win7 SP1

This maybe the bug in beta5 you are mentioning. We are currently using r7643. Will try to update to the latest.

Hi Niko,

I am looking at the input thing right now and I see that we load XInput dynamically

HMODULE xInput = LoadLibraryA("Xinput14.dll");

if (xInput != 0)

{

XInputGetState = (PFNXINPUTGETSTATE)GetProcAddress(xInput, "XInputGetState");

XInputGetCapabilities = (PFN_XINPUTGETCAPABILITIES)GetProcAddress(xInput, "XInputGetCapabilities");

}

So we shouldn't have that dependency at launch time. Could you please give me more information about the error?

Thanks!

Could you provide minidump using our latest beta release?

https://www.noesisengine.com/forums/viewtopic.php?f=14&t=1491

Hi Jesus,

I attached a patch to comment out the offending part of the current source code.
XInputGetCapabilities_ may be called even when it is not initialized (as in Win7)

Index: Src/Packages/App/Win32Display/Src/Win32Display.cpp
===================================================================
--- Src/Packages/App/Win32Display/Src/Win32Display.cpp	(revision 7801)
+++ Src/Packages/App/Win32Display/Src/Win32Display.cpp	(working copy)
@@ -345,13 +345,13 @@
             if (currentTime - lastEnumTime > 2000)
             {
                 lastEnumTime = currentTime;
-                XINPUT_CAPABILITIES xinputCaps;
-                uint32_t capsResult = XInputGetCapabilities_(0, XINPUT_FLAG_GAMEPAD, &xinputCaps);
-                if (capsResult == ERROR_SUCCESS)
-                {
-                    NS_LOG_DEBUG("XInput controller connected");
-                    isControllerConnected = true;
-                }
+                // XINPUT_CAPABILITIES xinputCaps;
+                // uint32_t capsResult = XInputGetCapabilities_(0, XINPUT_FLAG_GAMEPAD, &xinputCaps);
+                // if (capsResult == ERROR_SUCCESS)
+                // {
+                //     NS_LOG_DEBUG("XInput controller connected");
+                //     isControllerConnected = true;
+                // }
             }
         }
 

I updated our Noesis to 2.2.0b6 (r7766) and I confirmed that our code no longer crashes in Win7 SP1

So, just checking if XInputGetCapabilities_ is NULL before calling will solve the issue right?

I mean, the problem is that in Win7 that pointer is NULL or uninitiated.

I mean, the problem is that in Win7 that pointer is NULL or uninitiated.

Yes, that's correct.

Thanks for the help Niko! Fixed in r7850