0001800: "Virtualization disabled" reporting is not helpful

ID	Project	Category	View Status	Date Submitted	Last Update

0001800	NoesisGUI	C# SDK	public	2020-09-25 21:04	2020-09-28 14:18

Reporter	ai_enabled	Assigned To	sfernandez
Priority	normal	Severity	trivial
Status	assigned	Resolution	open
Product Version	3.0.6

Summary	0001800: "Virtualization disabled" reporting is not helpful
Description	Hi guys, firs of all, good job on 3.0.6 patch! I've noticed that log callback in NoesisGUI sometimes brings redundant information and so makes the feature useless (I just getting the same spam again and again and eventually have to disable the feature). For example, I have a ListBox that doesn't have a ScrollViewer in its ListBox.Template. Still, I get this warning message: "Virtualization disabled: items control IsVirtualizing is False" I've tried to decorate that ListBox with ScrollViewer.VerticalScrollBarVisibility="Disabled" VirtualizingStackPanel.IsVirtualizing="False" but I still get the same warnings. Regards!

Platform	Any

sfernandez 2020-09-28 10:29 manager ~0006653	Thanks! If the ListBox doesn't have a ScrollViewer why is it using a VirtualizingStackPanel? Shouldn't you change ItemsPanel to a simple StackPanel? Those messages are there to help identify the situations where VirtualizingStackPanel is not virtualizing anything, so using a StackPanel should fit better. Maybe we can detect that IsVirtualizing is explicitly set to "False", and don't show the warning in that case.

ai_enabled 2020-09-28 14:18 updater ~0006655	Thanks! I was under impression that I'm not using VirtualizingStackPanel in the base class. Adding custom override for ItemsControl.ItemsPanel to use simple StackPanel for ListBox resolved the issue. Maybe we can detect that IsVirtualizing is explicitly set to "False", and don't show the warning in that case. This idea is good but I can imagine it may be a problem to implement it this way. I think the suggestion to not use VirtualizingStackPanel is a proper approach in that case. Perhaps you can expand "Virtualization disabled: items control IsVirtualizing is False". I really cannot imagine the case when I need to disable virtualization for an ItemsControl with a VirtualizingStackPanel. I will simply override the Panel property to use regular StackPanel.

Date Modified	Username	Field	Change
2020-09-25 21:04	ai_enabled	New Issue
2020-09-25 21:05	ai_enabled	Description Updated
2020-09-25 21:05	ai_enabled	Description Updated
2020-09-25 21:05	ai_enabled	Product Version	3.0.7 => 3.0.6
2020-09-25 21:05	ai_enabled	Description Updated
2020-09-28 10:29	sfernandez	Assigned To	=> sfernandez
2020-09-28 10:29	sfernandez	Status	new => feedback
2020-09-28 10:29	sfernandez	Note Added: 0006653
2020-09-28 14:18	ai_enabled	Note Added: 0006655
2020-09-28 14:18	ai_enabled	Status	feedback => assigned