|
Another one:
Summary
NoesisEditor.cs enters an infinite DllNotFoundException error loop on every editor update tick when the Noesis native library is not available (e.g., Linux CI runners where only the Windows .dll is shipped). This floods the Unity log at hundreds of lines per second and fills the GitLab CI 64MB log buffer.
Root Cause
In NoesisUnity.cs, the Init() method sets _initialized = true (line 45) before calling InitCore() (line 53):
_initialized = true; // ← set BEFORE native calls
SetLicense();
RegisterLog();
InitCore(); // ← calls DisableSocketInit() → throws DllNotFoundException
InitCore() calls Noesis.GUI.DisableSocketInit(), which throws DllNotFoundException when the native library is missing. The exception propagates, but _initialized is already true.
In NoesisEditor.cs, the static constructor registers an EditorApplication.update callback:
EditorApplication.update += () =>
{
if (NoesisUnity.Initialized) // ← true, because _initialized was set before the crash
{
Noesis.GUI.UpdateInspector(); // ← also throws DllNotFoundException every tick
}
};
Since NoesisUnity.Initialized returns true (despite init having failed), UpdateInspector() is called every editor update tick, throwing DllNotFoundException indefinitely.
Note: This is the same class of bug that was previously fixed in NoesisLangServer.cs, where a DllNotFoundException catch was added to disable the update callback after the first failure.
Impact
CI pipelines running Unity on Linux are severely impacted
64MB log buffer fills, suppressing all subsequent output including test/build results
Editor may appear to hang (consuming CPU on exception handling)
Reproduction Steps
Set up a Unity project with NoesisGUI on a Linux machine (or Docker container) where only the Windows native library is present
Run Unity in batch mode: unity-editor -batchmode -nographics -runTests -testPlatform EditMode -logFile -
Observe the log flooding with DllNotFoundException from NoesisEditor.cs:13 on every tick
Suggested Fix
Wrap the update callback to catch DllNotFoundException and disable itself, matching the pattern already used in NoesisLangServer.cs:
private static bool _isDisabled = false;
static NoesisEditor()
{
EditorApplication.update += () =>
{
if (!_isDisabled && NoesisUnity.Initialized)
{
try
{
Noesis.GUI.UpdateInspector();
}
catch (DllNotFoundException)
{
_isDisabled = true;
}
}
};
// ... rest unchanged
}
Alternatively, the root cause in NoesisUnity.Init() could be fixed by moving _initialized = true to after InitCore() succeeds, or wrapping InitCore() in a try/catch that resets _initialized = false on failure. |
