 |
Hi, is there any update on this feature ? Is it gonna make it to 2.2.0 maybe ? |
 |
Hi Niko, we discussed long time ago and decided to add a char* to our cursors to solve this. But we are almost ready to close 2.2 (RC is happening this week) so I am not sure if we can implement it for this version. Could you please raise the priority of this ticket and tell me how critical it is for you right now? Thanks! |
|
|
Hi Jesus, I raised the priority to High. I think I can temporarily workaround this issue by providing per-view mapping from the current Cursor enum to the custom cursor inside the Integration layer. Please consider adding the official support in the near future. |
|
|
Hi Jesus, is there any update on this issue ? |
|
|
Hi Niko, Really sorry about this delay. I was talking with @sfernandez and we are going to solve this in 3.1.2. Is that ok for you? The idea is changing the definition of Cursor in typedef void (*UpdateCursorCallback)(void* user, IView* view, Cursor cursor); Cursor will be something like: struct Cursor
{
CursorType type;
String uri;
}
CursorType will be the old enum with a new entry Cursor_Custom indicating that the uri must be read. The uri will containt the .cur file, that must be loaded in each Display. You only need this for Windows right? |
|
|
Hi Jesus, Yes, we only need this for Windows. So, how can we use it from Xaml? Is it something like: <Grid Cursor="Custom_MyCursor"></Grid> in which uri will be set to "MyCursor" ? As for fix version, 3.1.2 is fine with us. |
|
|
To be compatible with Blend it needs to be<Grid Cursor="Custom_MyCursor.cur"></Grid> and you need to have MyCursor.cur in the Blend project. Our Win32Display implementation will load that .cur file. Will that work for you? |
|
|
@sfernandez I am not sure if the .cur extension is mandatory |
 |
Looking at WPF implementation of CursorConverter it seems they only support .cur and .ani files (apart from default known cursors): https://referencesource.microsoft.com/#PresentationCore/Core/CSharp/System/Windows/Input/CursorConverter.cs,176 |
|
|
> To be compatible with Blend it needs to be > <Grid Cursor="Custom_MyCursor.cur"></Grid> And I suppose I can pass uri as part of the string right ? e.g. <Grid Cursor="Custom_Resources/Cursor/MyCursor.cur"></Grid> > and you need to have MyCursor.cur in the Blend project. > Our Win32Display implementation will load that .cur file. > Will that work for you? Yes, that will work for us. Thanks! |
|
|
Great, thank you. More questions, should our implementation of Win32Display load the cursors? Or that's something you plan to do. If our implementation does it, we need to load the file using our file providers (we will use the XamlProvider I think, because it provides a IStream interface). |
|
|
> Great, thank you. More questions, should our implementation of Win32Display load the cursors? Or that's something you plan to do. We are using our own implementation of Win32Display (because we need to support multiple views inside a process). But we would appreciate if you can provide the example inside your Win32Display for us to follow. |
|
|
r10741 implemented the core changes. We still need to fix Displays and implement loading .cur files in Win32Display |
|
|
Hi Niko, I have been testing the implementation for Win32Display and everything is working fine but we are not going to make changes to Win32Display for loading custom cursors because there are many possible approaches to this: loading the cursor for memory, loading the cursor from file, loading the cursor for the resource table of the executable. I think, you are probably going to have an array with all your custom cursors loaded from file (or from the resource table) and then read that table when the request of changing cursor arrives to the Display. I took your example: <Window x:Class="WpfApp.MainWindow"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:local="clr-namespace:WpfApp"
mc:Ignorable="d"
Title="MainWindow" Height="350" Width="525">
<Window.Resources>
<ResourceDictionary>
<Cursor x:Key="CursorMagnify">C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\atlmfc\include\res\magnify.cur</Cursor>
</ResourceDictionary>
</Window.Resources>
<Grid Cursor="{StaticResource CursorMagnify}">
<TextBlock>test</TextBlock>
</Grid>
</Window>
And added the following change to our Win32Display: case WM_SETCURSOR:
{
if (LOWORD(lParam) == HTCLIENT)
{
if (mCursor.type == Cursor::Custom)
{
HCURSOR cur = LoadCursorFromFileA(mCursor.filename.Str());
::SetCursor(cur);
}
else
{
if (mCursors[mCursor.type] != 0)
{
::SetCursor(mCursors[mCursor.type]);
return true;
}
}
}
return false;
}
And it works, the custom cursor changes. This implementation is not efficient because the cursor is loaded per frame, but I just wanted to use it to check everything is working correctly. As said, we are not going to commit any change to Win32Display but if you need more help or have doubts please write us or reopen the ticket. Thanks for your patience! |
|
|
I think we finally can close this : ) |
- Anonymous
