|
|
I also needed to apply the following patch. Seems to be the same issue as here: https://github.com/electronicarts/EASTL/issues/274
string.h.patch (812 bytes)
Index: 3rdParty/EASTL/local/include/EASTL/string.h
===================================================================
--- 3rdParty/EASTL/local/include/EASTL/string.h (revision 136058)
+++ 3rdParty/EASTL/local/include/EASTL/string.h (working copy)
@@ -529,7 +529,7 @@
///////////////////////////////////////////////////////////////////////////////
// 'char traits' functionality
//
- inline char8_t CharToLower(char c)
+ inline char8_t CharToLower(char8_t c)
{ return (char8_t)tolower((uint8_t)c); }
inline char16_t CharToLower(char16_t c)
@@ -610,7 +610,7 @@
}
- inline size_t CharStrlen(const char* p)
+ inline size_t CharStrlen(const char8_t* p)
{
#ifdef _MSC_VER // VC++ can implement an instrinsic here.
return strlen(p);
|
|
|
|
Hi Niko, are those errors the only problems you have?
We already have a branch (almost ready to be integrated into trunk) with no EASTL at all :) |
|
|
|
Yes, those are all problems that I found. I also need to change the Platform Toolset on all vcxproj files to use VC++ 2019.
We are now using VS2019 with slightly patched Noesis. |
|
|
|
This is also a problem in VS2019 16.3.0
https://developercommunity.visualstudio.com/content/problem/734566/msvc-142328019-is-missing-include-typeinfoh.html
Need to change typeinfo.h -> typeinfo |
|
|
|
We are no longer using STL or C++ includes (like typeinfo.h) in trunk but I recommend waiting a bit before using that version because the version is still unstable |
|
