View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001530 | NoesisGUI | C++ SDK | public | 2019-08-08 09:21 | 2021-07-27 20:04 |
Reporter | nikobarli | Assigned To | jsantos | ||
Priority | normal | Severity | feature | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | 2.2.3 | ||||
Target Version | 3.1 | Fixed in Version | 3.1.0 | ||
Summary | 0001530: VS2019 support | ||||
Description | Hi, we are starting to use VS2019. Could you consider adding official support for it ? Currently I found the following line generate warning -> converted to error. KeyboardNavigation.cpp line 828: float distanceX = fabs(mLeftBottom.x - leftBottom.x); -> conversion from double to float, possible loss of data I am using VS2019 16.2.0 | ||||
Tags | No tags attached. | ||||
Platform | Any | ||||
I also needed to apply the following patch. Seems to be the same issue as here: https://github.com/electronicarts/EASTL/issues/274 string.h.patch (812 bytes)
Index: 3rdParty/EASTL/local/include/EASTL/string.h =================================================================== --- 3rdParty/EASTL/local/include/EASTL/string.h (revision 136058) +++ 3rdParty/EASTL/local/include/EASTL/string.h (working copy) @@ -529,7 +529,7 @@ /////////////////////////////////////////////////////////////////////////////// // 'char traits' functionality // - inline char8_t CharToLower(char c) + inline char8_t CharToLower(char8_t c) { return (char8_t)tolower((uint8_t)c); } inline char16_t CharToLower(char16_t c) @@ -610,7 +610,7 @@ } - inline size_t CharStrlen(const char* p) + inline size_t CharStrlen(const char8_t* p) { #ifdef _MSC_VER // VC++ can implement an instrinsic here. return strlen(p); |
|
Hi Niko, are those errors the only problems you have? We already have a branch (almost ready to be integrated into trunk) with no EASTL at all :) |
|
Yes, those are all problems that I found. I also need to change the Platform Toolset on all vcxproj files to use VC++ 2019. We are now using VS2019 with slightly patched Noesis. |
|
This is also a problem in VS2019 16.3.0 https://developercommunity.visualstudio.com/content/problem/734566/msvc-142328019-is-missing-include-typeinfoh.html Need to change typeinfo.h -> typeinfo |
|
We are no longer using STL or C++ includes (like typeinfo.h) in trunk but I recommend waiting a bit before using that version because the version is still unstable | |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-08-08 09:21 | nikobarli | New Issue | |
2019-08-08 10:57 | nikobarli | File Added: string.h.patch | |
2019-08-08 10:57 | nikobarli | Note Added: 0005914 | |
2019-08-08 12:55 | jsantos | Assigned To | => jsantos |
2019-08-08 12:55 | jsantos | Status | new => assigned |
2019-08-08 12:56 | jsantos | Note Added: 0005915 | |
2019-08-08 12:57 | jsantos | Status | assigned => feedback |
2019-08-09 07:18 | nikobarli | Note Added: 0005921 | |
2019-08-09 07:18 | nikobarli | Status | feedback => assigned |
2019-09-25 06:43 | nikobarli | Note Added: 0005965 | |
2019-09-26 15:17 | jsantos | Note Added: 0005966 | |
2020-06-22 21:08 | jsantos | Status | assigned => resolved |
2020-06-22 21:08 | jsantos | Resolution | open => fixed |
2020-06-22 21:08 | jsantos | Fixed in Version | => 3.1 |
2020-06-22 21:08 | jsantos | Target Version | => 3.1 |
2021-07-27 20:04 | jsantos | Fixed in Version | 3.1 => 3.1.0 |