 |
Is there any info on this? It actually gets really bad in larger projects. Changing a single value in an XAML forces the import for 10 - 15 files, and then losing and gaining focus of Unity does this again. This exactly project had none of these issues in 2.x. https://files.catbox.moe/378irf.mp4 |
 |
Hi, we are currently studying this problem as we still have access to your project. The first thing I noticed is that you have a folder named Unused with lots of xamls that are giving errors, and from the name of the folder it seems to me those are old files, couldn't you take them outside Assets to avoid getting undesired error messages? Regarding the modification of CustomViews.xaml that triggers the import of the rest of xamls, that is happening because that xaml is a dependency of your ApplicationResources (Resources.xaml), and whenever that xaml gets reimported, all xamls need to be reimported as it is a dependency of all of them. The imports occurring after you regain focus on Unity is because Unity processes the import of dependencies in background processes when it determines it is appropriate. Anyway, we'll investigate the hot-reloading of xamls after the reimport because we should be able to restore the state of the game without breaking things. |
|
|
We fixed a problem with hot-reloading initializing elements before setting its properties. Apart from that your game logic is adding elements in code that get destroyed when xaml is reloaded. For example, your MainGameBehavior is adding the MainMenu to the View on Start. You can hook to the Reloaded event there to add the menu again: if (MainView?.Content != null)
{
MainView.Content.Reloaded += (s, e) =>
{
FrameManager.Get("Main").Push("MainMenu", new NavParams(hasAnimation: false, canBack: false));
};
}And those dynamic elements added to the NavFrame, when that control gets reloaded will also be removed them from the "ContentRoot" grid because it gets filled with the "Overlay" button defined in the xaml. Wouldn't be better in that control to add the dynamic elements to a sibling of the "Overlay" button, something like this: <Grid>
<Button
x:Name="Overlay"
Click="Overlay_Click"
Visibility="Collapsed">
<Button.Style>
<Style BasedOn="{StaticResource {x:Type Button}}" TargetType="Button">
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
<Grid Background="{TemplateBinding Background}" />
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
</Button.Style>
<Button.Background>
<SolidColorBrush Opacity=".4" Color="Black" />
</Button.Background>
</Button>
<Grid x:Name="ContentRoot"/>
</Grid>This way you don't even need to change the ZIndex of the Overlay button because the dynamic elements will always be added on top. |
 |
One of the things we have new in 3.X is that when the Application resources is modified (or any of its dependencies) *ALL* xamls are reimported (to get errors and thumbnails). I don't know if we should consider having a way to disable this... |
|
|
Sorry, I wasn't sure how to reply without reopening this ticket. Thanks for the help! I didn't know about Reloaded, I will try to implement this for NavFrame to automatically recreate the page stack. About the overlay, it is possible for some pages to behind the overlay. For example, if there are three pages and the top page has an overlay, the overlay would have to be between the second and third page. This is why I found it easier to set the ZIndex in the code behind. If this doesn't relate to what you were suggesting, can you explain how your example would be different? Thanks again! |
|
|
We are measuring times again, probably reloading all XAMLs when the global dictionary changes was not a good idea... |
|
|
Reloading of Xamls, including dependencies from Application resources should be now much faster. Thanks for your feedback. Please, let us know about all issues you find with hot-reloading. |
- Anonymous
