View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002398NoesisGUIC++ SDKpublic2022-08-16 07:262023-07-05 01:00
ReporterBAJayM Assigned Tojsantos  
PrioritynormalSeverityminor 
Status resolvedResolutionreopened 
Product Version3.1.5 
Target Version3.2.2Fixed in Version3.1.6 
Summary0002398: Hitting assert in Rect constructor when using LinearRectKeyFrame
Description

There is a case where the LinearRectKeyFrame can case the rect constructor to assert while it is animating.

I believe it is using the rect class to do some maths to work out the new location of the rect. This rect that you are using, can have a negative size but it should be valid.

Steps To Reproduce

Say we have a rectangle geometry like this:
<RectangleGeometry x:Name="outlineColourAwaySideGeo" Rect="0, 0, 533, 400"/>

Then we have a storyboard that moves it like this:

<RectAnimationUsingKeyFrames Storyboard.TargetName="outlineColourAwaySideGeo"
BeginTime="0:0:0"
Storyboard.TargetProperty="Rect">
<LinearRectKeyFrame Value="0,0,533,0" KeyTime="0:0:0.4" />
<DiscreteRectKeyFrame Value="0,0,533,400" KeyTime="0:0:0.6" />
</RectAnimationUsingKeyFrames>

The rect you are doing the maths with has a negative size so therefore hits this assert.

PlatformAny

Activities

BAJayM

BAJayM

2023-06-09 07:02

reporter   ~0008531

I've just merged the fix for this into 3.1.5 (we still haven't updated. It's been crazy) and I saw the same problem would be in Spline Rect Key Frame and Easing Rect Key Frame
jsantos

jsantos

2023-07-05 00:02

manager   ~0008582

I am verifying this right now, the original fix for LinearRectKeyFrame was in r11689. A day later, r11698 fixed this for all animation classes using Rect.

Could you please verify you merged everything correctly?

This is also part of Noesis 3.2 branch.
BAJayM

BAJayM

2023-07-05 00:46

reporter   ~0008583

Oh I must of missed that. Ill take a look thank you.

We haven't updated fully since we are under the pump atm.
Thanks for pointing that out. My bad.

Thanks,
Jay
jsantos

jsantos

2023-07-05 01:00

manager   ~0008584

I am going to mark this as solved. Please, reopen again if necessary.

Issue History

Date Modified Username Field Change
2022-08-16 07:26 BAJayM New Issue
2022-08-16 07:26 BAJayM Tag Attached: assert
2022-08-16 07:26 BAJayM Tag Attached: LinearRectKeyFrame
2022-08-16 11:23 sfernandez Assigned To => sfernandez
2022-08-16 11:23 sfernandez Status new => assigned
2022-08-16 11:23 sfernandez Assigned To sfernandez => jsantos
2022-08-16 11:23 sfernandez Target Version => 3.1.6
2022-11-07 17:13 sfernandez Target Version 3.1.6 => 3.1.7
2022-11-07 17:16 sfernandez Target Version 3.1.7 => 3.1.6
2022-11-08 00:58 jsantos Status assigned => resolved
2022-11-08 00:58 jsantos Resolution open => fixed
2022-11-08 00:58 jsantos Fixed in Version => 3.1.6
2023-06-09 07:02 BAJayM Status resolved => feedback
2023-06-09 07:02 BAJayM Resolution fixed => reopened
2023-06-09 07:02 BAJayM Note Added: 0008531
2023-06-12 16:03 jsantos Target Version 3.1.6 => 3.2.2
2023-07-04 19:50 jsantos Status feedback => assigned
2023-07-05 00:02 jsantos Note Added: 0008582
2023-07-05 00:02 jsantos Status assigned => feedback
2023-07-05 00:46 BAJayM Note Added: 0008583
2023-07-05 00:46 BAJayM Status feedback => assigned
2023-07-05 01:00 jsantos Status assigned => resolved
2023-07-05 01:00 jsantos Note Added: 0008584