|
|
Thanks for catching this! Patch fixing the issue:
Index: String.inl
--- String.inl (revision 11729)
+++ String.inl (working copy)
@@ -430,10 +430,17 @@
NS_ASSERT(pos <= mSize);
NS_ASSERT(str != nullptr);
-
char* dest = Begin() + pos;
uint32_t removes = Min(n, mSize - pos);
uint32_t inserts = (uint32_t)strlen(str);
-
uint32_t newSize = mSize + inserts - removes;
-
if (NS_UNLIKELY(newSize > Capacity()))
-
{
-
Grow(newSize);
-
}
-
-
char* dest = Begin() + pos;
-
if (removes != inserts)
{
memmove(dest + inserts, dest + removes, mSize - pos - removes + 1);
@@ -440,7 +447,7 @@
}
memcpy(dest, str, inserts);
-
ForceSize(mSize + inserts - removes);
-
ForceSize(newSize);
}
////////////////////////////////////////////////////////////////////////////////////////////////////
|
