I am not able to reproduce this, I can "Right Click" on the map to create a "red waypoint", and then I can connect to new points with "Shift+Right Click".

Please, let me know how to reproduce.

Map.png (31,132 bytes)   

Map.png (31,132 bytes)   

You're right, I'm sorry. I thought it doesn't create those semi-transparent waypoints but apparently it's the same in 3.2.8 so clearly a bug on our side. Can be closed!

image.png (43,807 bytes)   

image.png (43,807 bytes)   

I'm sorry, have to reopen it. The issue is differently.

I'll create a short video to demonstrate it and to show how to reproduce it.

Ok, here's an example how it should look like. Please note I first switch to "light" mode so it's better visible.

You can clearly see the line to the first waypoint we set and that it also reacts accordingly. And also that the initial line to the left is now set to that first waypoint, so updated.

And here's what happens with Noesis 3.2.9. As you can see the original line stays and does not update to the new (first) waypoint you set:

You can see the difference on those screenshots (between yours and mine) as well.

Thanks for the report. I will have a look at it.

Are you 100% sure you started to see this with only upgrading to 3.2.9? No more changes on your side.

Yes that's exactly the same code beside the Noesis change.

As you can see the original line stays and does not update to the new (first) waypoint you set

Could you please give more context about how you are adding the new point and modifying the original line? Just an overview of the API you are using for this.

Edit: Sorry I cannot get the [code]...[/code] <code>...</code> blocks to work.

that's being done with

<mapControl:MapPolyline 
    x:Name="Host" 
    Stroke="{Binding Path=(viewmodels:NightModeBehaviour.CurrentColor), RelativeSource={RelativeSource Self}}"
    StrokeThickness="{sp:UIResource TM_WaypointLineThickness}"
    mapControl:MapPanel.ParentMap="{Binding RelativeSource={RelativeSource Mode=FindAncestor, AncestorType=mapControl:MapBase}}"
    Locations="{Binding LivePath}">
    <i:Interaction.Behaviors>
        <viewmodels:NightModeBehaviour
            DayColor="{sp:UIResource TM_WaypointsLineColor}" 
            NightColor="{sp:UIResource TM_Night_WaypointsLineColor}"/>
    </i:Interaction.Behaviors>
</mapControl:MapPolyline>

and then MapPolyline works with

public static readonly DependencyProperty LocationsProperty = DependencyProperty.Register(
  nameof(Locations), typeof(IEnumerable<GeoPosition>), typeof(MapPolyline),
  new PropertyMetadata(null, (o, e) => {
    ((MapPolyline)o).DataCollectionPropertyChanged(e);
    }));

that then does

protected void DataCollectionPropertyChanged(DependencyPropertyChangedEventArgs e)
{
  if (e.OldValue is INotifyCollectionChanged oldCollection)
  {
    CollectionChangedEventManager.Instance.RemoveListener(oldCollection, _handler);
  }

  if (e.NewValue is INotifyCollectionChanged newCollection)
  {
    CollectionChangedEventManager.Instance.AddListener(newCollection, _handler);
  }

  UpdateData(true);
}

that then does

protected override void UpdateData(bool dataUpdated = false)
{
  if (ParentMap != null && Locations != null)
  {
    //Debug.Log("Polyline update");
#if NOESIS
    _profPolylineUpdate.Begin();
#endif
    var (scaleMat, translation) = UnpackTransform(ParentMap.ViewTransform.MapToViewMatrix);
    _translateToPosition.X = translation.X;
    _translateToPosition.Y = translation.Y;
    if (scaleMat != _oldScale || _geom == null || dataUpdated)
    {
      _oldScale = scaleMat;
      _geom = MakePolylineGeometry();
    }
    InvalidateVisual();
    var longitudeOffset = Location != null ? GetLongitudeOffset(Location) : GetLongitudeOffset(Locations.FirstOrDefault());
    //AddPolylineLocations(Locations, longitudeOffset, false);
#if NOESIS
    _profPolylineUpdate.End();
#endif
  }
}

and then

protected override void OnRender(DrawingContext context)
{
  base.OnRender(context);
  context.PushTransform(_translateToPosition);
  if (_geom != null && Pen != null)
    context.DrawGeometry(null, Pen, _geom);
  context.Pop();
}

so in a high level summary Locations is a normal array that's atomically shuffled into a INotifyPropertyChanged parameter that then triggers a updated listener on a bound dependency property which updates the path geometry and invalidates the visual to trigger a render

Ah thank you! I see how to use the code blocks now.

I can’t associate this issue with any changes introduced in 3.2.9.

Could you please share the code for MakePolylineGeometry()?

It looks like two separate figures are being created, one for the original line on the left and another for the new polyline. However, in the original (first) video, I only see a single polyline.

Any news on this? We are going to release 3.2.10 very soon.

Thank you!

Hi sorry for the late answer, I was out of house. I've pinged Ben who's our dev for handling those special cases.

Sorry for the delay, the contents of MakePolylineGeometry are

    private StreamGeometry MakePolylineGeometry()
    {
      StreamGeometry geom = new StreamGeometry();
      using (var ctx = geom.Open())
      {
        if (Locations == null)
          return geom;
        var longitudeOffset = Location != null ? GetLongitudeOffset(Location) : GetLongitudeOffset(Locations.FirstOrDefault());
        for (int i = 0; i < Locations.Count(); i++)
        {
          var nextPt = _oldScale.Transform(LocationToMap(Locations.ElementAt(i), longitudeOffset));
          if (i == 0)
          {
            ctx.BeginFigure(nextPt, false, false);
            continue;
          }
          ctx.LineTo(nextPt, true, true);
          if (i > 0 && i % 30 == 0 && i != Locations.Count() - 1)
          {
            ctx.BeginFigure(nextPt, false, false); // make too-long paths into multiple
          }
        }
      }
      return geom;
    }

The two polylines (the static one that's not being updated realtime and the live one that is) are drawn separately for performance; it seems like only the one that's being regularly updated has stopped working.

Thanks for the information.

In the video waypoint-line-missing.mp4 posted above: "the original line stays and does not update to the new (first) waypoint you set".

How is that line rendered? Because it doesn't seem to be part of the polyline (code you posted), right?

It's rendered as its own polyline, through the earlier code that Xaron shared. We render two polylines, one for the live updated part (which is the code path that we shared earlier, and what is breaking) and for the static part (which is fine).
That initial leg is still a polyline, it just only has two points in it.

Watching the videos, I don't see any problems in the dynamic polyline.

The only problem I see is in the initial leg (polyline with two points). This leg is not connecting with the first point in the dynamic polyline.

Are you sure this leg polyline is being updated correctly?

Please, confirm.

My suspicion is that something in the DependencyProperty binding that updates the polyline used to render the initial leg broke in the upgrade, yes.

How is the second point of the leg connected to the first point of the dynamic polyline?

It isn't, they're separate objects. Sorry for the delay.

Thanks, could you show me the XAML and code where this leg is rendered and updated?

The XAML & C# is in Xaron's post up-thread already, the only thing above that is that LivePath is a INotifyPropertyChanged property with a List<GeoPosition> that notifies when the initial path is updated.

The XAML above has a binding to LivePath

Locations="{Binding LivePath}">

I think the leg poyline must be something different right?

Oh - LivePath is the polyline that's drawn from the unit to the first waypoint (or not drawn, as it might be), that's the code behind the part of the display that isn't working. I'll check this tomorrow though.

Okay, I looked into the implementation and the LivePath is indeed what isn't being drawn, so it's the above code path.
My suspicion is that the visual isn't being invalidated when the Locations DependencyProperty is getting updated, though I don't have a good hypothesis as for why that would stop working.

Please, provide a repro project for this.

Thank you!

We managed to fix it on our end using 3.2.10. So this can be closed. Thank you!

Thanks!