Actually, turns out the problem is because the TextBlock has a binding to Foreground like so:

<TextBlock Foreground="{Binding TextColorBrush}" />

And TextColor is a reference to the original Color brush (which I get from the ResourceDictionary programmatically), and is getting modified because of the binding. Setting Mode=OneWay does not solve the problem unfortunately.

Hi,

I tried the following sample in WPF:

<Grid
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Background="Red">
<Grid.Resources>
<Color x:Key="Theme1Color">#FFFFFFFF</Color>
<Color x:Key="Theme2Color">#FF000000</Color>
<SolidColorBrush x:Key="TextColorBrush" Color="{DynamicResource Theme1Color}"/>
<Storyboard x:Key="ChangeSelectedTextColorTransition">
<ColorAnimationUsingKeyFrames
Storyboard.TargetName="txt"
Storyboard.TargetProperty="(TextBlock.Foreground).(SolidColorBrush.Color)">
<EasingColorKeyFrame KeyTime="0:0:0" Value="{StaticResource Theme1Color}" />
<EasingColorKeyFrame KeyTime="0:0:2" Value="{StaticResource Theme2Color}" />
</ColorAnimationUsingKeyFrames>
</Storyboard>
</Grid.Resources>
<Grid.Triggers>
<EventTrigger RoutedEvent="FrameworkElement.Loaded">
<EventTrigger.Actions>
<BeginStoryboard Storyboard="{StaticResource ChangeSelectedTextColorTransition}"/>
</EventTrigger.Actions>
</EventTrigger>
</Grid.Triggers>
<Rectangle x:Name="rect" Fill="{StaticResource TextColorBrush}" Width="200" Height="100"/>
<TextBlock x:Name="txt" Text="Hello World" FontSize="40" Foreground="{Binding Fill, ElementName=rect}"/>
</Grid>

And the animation is modifying the color of the rectangle too, so I think we are doing the correct thing here.

You can Freeze the resource obtained from the ResourceDictionary, so it gets cloned when animation tries to modify it.

Let me know if this solution works for you.

I'm not sure that's a viable solution. To me, the Color itself should not change. It should be making a copy of the color and animating that rather than modifying the original resource. We use the same color key throughout the application so it's not possible for us to Freeze the value every time we need to animate it.

Right now, we have to animate everything through code to prevent this issue. Our current solution is something along the lines of:

    private ColorAnimation CreateSelectAnimation()
    {
        var colorAnim = new ColorAnimation();

        colorAnim.SetFrom(new NullableColor(Theming.GetColor("BlackColor")));
        colorAnim.SetTo(new NullableColor(Theming.GetColor("Theme1Color")));
        colorAnim.SetDuration(new Duration(new TimeSpan(0.250)));

        return colorAnim;
    }

And this is our other animation code for animating a color when we don't know what color we're animating from:

    private void Animate(TextBlock depObj, Action callback)
    {
        var sb = new Storyboard();
        var currentColor = depObj.GetForeground().As<SolidColorBrush>().GetColor();

        //TODO: Refactor once we get DataTriggers.
        //Bug in Noesis prevents us from using the values directly in a storyboard...
        depObj.SetForeground(new SolidColorBrush(new Color(currentColor.GetRedF(), currentColor.GetGreenF(), currentColor.GetBlueF(), currentColor.GetAlphaF())));

        Storyboard.SetTarget(_selectAnimation, depObj);
        Storyboard.SetTargetProperty(_selectAnimation, new PropertyPath("(TextBlock.Foreground).(SolidColorBrush.Color)"));

        sb.GetChildren().Add(_selectAnimation);
        BeginStoryboard(depObj, sb, callback);
    }

Hi Sergio, I looked into this a little further as I encountered this problem again. The way to fix it in WPF is to add 'x:Shared="False"' to the SolorColorBrush. This isn't supported in the Unity version of Noesis, but it would solve the problem. This creates a new instance of the color object instead of using the reference. Here's the working WPF example:

<Grid
    Background="Red">
    <Grid.Resources>
        <Color x:Key="Theme1Color">#FFFFFFFF</Color>
        <Color x:Key="Theme2Color">#FF000000</Color>
        <SolidColorBrush x:Key="Theme1Brush" x:Shared="False" Color="{StaticResource Theme1Color}" />
        <SolidColorBrush x:Key="Theme2Brush" x:Shared="False" Color="{StaticResource Theme2Color}" />

        <Storyboard x:Key="ChangeSelectedTextColorTransition">
            <ColorAnimationUsingKeyFrames RepeatBehavior="Forever"
                                          AutoReverse="True"
                                          Storyboard.TargetName="txt"
                                          Storyboard.TargetProperty="(TextBlock.Foreground).(SolidColorBrush.Color)">
                <EasingColorKeyFrame KeyTime="0:0:0" Value="{StaticResource Theme1Color}" />
                <EasingColorKeyFrame KeyTime="0:0:2" Value="{StaticResource Theme2Color}" />
            </ColorAnimationUsingKeyFrames>
        </Storyboard>
    </Grid.Resources>

    <Grid.Triggers>
        <EventTrigger RoutedEvent="FrameworkElement.Loaded">
            <EventTrigger.Actions>
                <BeginStoryboard Storyboard="{StaticResource ChangeSelectedTextColorTransition}" />
            </EventTrigger.Actions>
        </EventTrigger>
    </Grid.Triggers>

    <Rectangle x:Name="rect" Fill="{StaticResource Theme1Brush}" Width="200" Height="100" />
    <TextBlock x:Name="txt" Text="Hello World" FontSize="40" Foreground="{StaticResource Theme1Brush}" />
</Grid>